[RPC] Add endpoint for fetching CoinMetadata #6281
Conversation
666lcz
requested review from
patrickkuo,
gegaowp,
sblackshear,
Jordan-Mysten,
longbowlu,
damirka and
tnowacki
|
💳 Wallet Extension has been built, you can download the packaged extension here: https://github.com/MystenLabs/sui/actions/runs/3561669260#artifacts |
666lcz
force-pushed
the
chris-coin-standard-1
branch
from
f2465dc
to
441ca0b
Compare
666lcz
force-pushed
the
chris-coin-standard-1
branch
from
441ca0b
to
a7b6641
Compare
| @@ -66,7 +66,7 @@ export function useCoinDecimals(coinType?: string | null) { | |||
| ); | |||
| } | |||
|
|
|||
| return rpc.getCoinDenominationInfo(coinType); | |||
| return rpc.getCoinMetadata(coinType); | |||
There was a problem hiding this comment.
@666lcz what happens if this method isn’t available? This is currently hardcoded for SUI so I’m worried that this will break sui display for networks that don’t yet support this
There was a problem hiding this comment.
Good catch! I just added the logic to return hardcoded value for SUI if the RPC version is prior to 0.17.0
| @@ -151,6 +155,78 @@ impl RpcFullNodeReadApiServer for FullNodeApi { | |||
| Ok(self.state.dry_exec_transaction(tx_data, txn_digest).await?) | |||
| } | |||
|
|
|||
| async fn get_coin_metadata(&self, coin_type: String) -> RpcResult<SuiCoinMetadata> { | |||
There was a problem hiding this comment.
This looks quite expensive? We are pulling out the package object every time we need to get the coin's metadata.
if this is frequently accessed, maybe we can consider creating a mapping in AuthorityPerpetualTables?
666lcz
force-pushed
the
chris-coin-standard-1
branch
from
a7b6641
to
f99da69
Compare
666lcz
force-pushed
the
chris-coin-standard-1
branch
from
f99da69
to
62b6685
Compare
Add convenience endpoints for fetching
CoinMetadatalands after #5635